workaroud for the flaky oidc e2e test #4603
Open
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
flaky-oidc-workaround
branch
2 times, most recently
from
7bbdd8e
to
83e4971
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4603 +/- ##
==========================================
+ Coverage 65.43% 65.45% +0.02%
==========================================
Files 211 211
Lines 31904 31904
==========================================
+ Hits 20875 20883 +8
+ Misses 9784 9778 -6
+ Partials 1245 1243 -2 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
flaky-oidc-workaround
branch
from
83e4971
to
e5f3897
Compare
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
flaky-oidc-workaround
branch
from
e5f3897
to
21fb4f1
Compare
zirain
reviewed
Nov 1, 2024
Signed-off-by: Huabing Zhao <[email protected]>
zirain
reviewed
Nov 1, 2024
| // restart the envoy proxy to recover from the error, this is a workaround for the flaky test: https://github.com/envoyproxy/gateway/issues/3898 | ||
| // TODO: we should investigate the root cause of the flakiness and remove this workaround | ||
| proxyLabel := map[string]string{"gateway.envoyproxy.io/owning-gateway-name": "same-namespace"} | ||
| err := suite.Client.DeleteAllOf(context.TODO(), &corev1.Pod{}, client.MatchingLabels(proxyLabel), client.InNamespace("envoy-gateway-system")) |
There was a problem hiding this comment.
should we force a rollout/restart instead of deleting?
There was a problem hiding this comment.
It doesnt matter here. We just need to restart the Envoy pod to repush the xDS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restart Envoy to recover from the OIDC test failure. This is just a workaround to reduce the time of e2e test due to the failed OIDC test. We still need to investage the root cause and fix it.
Related issue: #3898
Release Notes: No