fix: Route with multiple parents has incorrect namespace in parentRef status #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
commented
Oct 31, 2024
| routeParentStatusIdx := -1 | ||
| defaultNamespace := gwapiv1.Namespace(metav1.NamespaceDefault) |
There was a problem hiding this comment.
This is the root cause of the bug.
|
@guydc this is worth cherry-picking into v1.1.3. It happens whenever a xRoute targets multple Gateways in the same ns. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
==========================================
+ Coverage 65.41% 65.44% +0.02%
==========================================
Files 211 211
Lines 31887 31904 +17
==========================================
+ Hits 20859 20878 +19
Misses 9782 9782
+ Partials 1246 1244 -2 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
fix-status-wrong-ns
branch
from
1a8613e
to
5b4e065
Compare
zhaohuabing
changed the title
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-status-wrong-ns
branch
from
6642ccb
to
095e62d
Compare
zirain
approved these changes
Nov 1, 2024
zhaohuabing
added a commit
to zhaohuabing/gateway
that referenced
this pull request
Nov 1, 2024
… status (envoyproxy#4592) fix route status wrong ns Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 7285dda) Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4127
Release Notes: Yes