Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.2] Cherry pick the PRs in v1.2 milestone #4560

Draft
wants to merge 12 commits into
base: release/v1.2
Choose a base branch
from

Conversation

zhaohuabing
Copy link
Member

No description provided.

zhaohuabing and others added 5 commits October 29, 2024 02:31
…oyproxy#4499)

* validate proto message before converting to any

Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit 05817fc)
Signed-off-by: Huabing Zhao <[email protected]>
…d friendly (envoyproxy#4505)

* Reduce the amount and style of configuration logging

Signed-off-by: Evan Anderson <[email protected]>

* Update verbosity from 1->4

Signed-off-by: Evan Anderson <[email protected]>
Signed-off-by: Evan Anderson <[email protected]>

---------

Signed-off-by: Evan Anderson <[email protected]>
Signed-off-by: Evan Anderson <[email protected]>
(cherry picked from commit 7897fc5)
Signed-off-by: Huabing Zhao <[email protected]>
* make watching alpha CRDs optional

* The ownership of CRD installation is not tied to a single entity
https://gateway-api.sigs.k8s.io/guides/crd-management/#who-should-manage-crds
This results in multiple entities taking ownership of CRD installation
  * infra users
  * implementations
  * cloud providers

This complicates things for implementations who may not know which
version and release of CRDs are installed, so this PR makes watching
alpha versioned CRDs optional

* Even Envoy Gateway specific CRDs have been made optional to solve the
  use case where users want to only configure Gateway API resources

* GRPCRoute is the only exception, which is v1, but has been made
  optional because it just graduated to v1 in v1.2
  but a lot of cloud providers or service mesh implementations
  have not moved to v1.2

Fixes: envoyproxy#3387

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit b877bac)
Signed-off-by: Huabing Zhao <[email protected]>
…hout sha (envoyproxy#4547)

* fix wasm http code source without sha

Signed-off-by: Huabing Zhao <[email protected]>

* release note

Signed-off-by: Huabing Zhao <[email protected]>

* fix gen

Signed-off-by: Huabing Zhao <[email protected]>

* fix gen

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit 74e5750)
Signed-off-by: Huabing Zhao <[email protected]>
* e2e test for Gateway with EnvoyProxy

Signed-off-by: Huabing Zhao <[email protected]>

* remove unnecessary comments

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit 217c6a5)
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner October 29, 2024 02:38
@zhaohuabing zhaohuabing marked this pull request as draft October 29, 2024 02:38
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 46.91176% with 361 lines in your changes missing coverage. Please review.

Project coverage is 65.48%. Comparing base (19eb5f5) to head (862c74f).

Files with missing lines Patch % Lines
internal/provider/kubernetes/controller.go 44.01% 123 Missing and 64 partials ⚠️
internal/provider/kubernetes/predicates.go 48.12% 66 Missing and 17 partials ⚠️
internal/xds/translator/listener.go 55.00% 12 Missing and 6 partials ⚠️
internal/provider/kubernetes/indexers.go 0.00% 16 Missing and 1 partial ⚠️
internal/xds/translator/accesslog.go 34.78% 10 Missing and 5 partials ⚠️
internal/xds/translator/translator.go 35.29% 7 Missing and 4 partials ⚠️
internal/provider/kubernetes/routes.go 20.00% 6 Missing and 2 partials ⚠️
internal/xds/translator/authorization.go 20.00% 0 Missing and 8 partials ⚠️
internal/utils/protocov/protocov.go 71.42% 3 Missing and 1 partial ⚠️
internal/xds/translator/custom_response.go 20.00% 0 Missing and 4 partials ⚠️
... and 4 more
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.2    #4560      +/-   ##
================================================
- Coverage         65.66%   65.48%   -0.18%     
================================================
  Files               211      211              
  Lines             31669    31882     +213     
================================================
+ Hits              20794    20879      +85     
- Misses             9671     9760      +89     
- Partials           1204     1243      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tamalsaha and others added 7 commits October 30, 2024 02:08
* Make security context configurable

Signed-off-by: Tamal Saha <[email protected]>

* make gen-check

Signed-off-by: Tamal Saha <[email protected]>

* Update current.yaml

Signed-off-by: Tamal Saha <[email protected]>

---------

Signed-off-by: Tamal Saha <[email protected]>
(cherry picked from commit 20a4622)
Signed-off-by: Huabing Zhao <[email protected]>
* ci: enable dual stack test

Signed-off-by: zirain <[email protected]>

* more comment

Signed-off-by: zirain <[email protected]>

* remove 1.31.0 ipv4 test suite

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
(cherry picked from commit bb3bbdb)
Signed-off-by: Huabing Zhao <[email protected]>
* the release artifact for `egctl` was being pulled from
the `latest` release instead of a binary associated with
the release tag

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit 82ce107)
Signed-off-by: Huabing Zhao <[email protected]>
envoyproxy#4581)

fix: trigger reconcile for Secret updates referenced by a BackendTLSPolicy

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit db68027)
Signed-off-by: Huabing Zhao <[email protected]>
https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details
```
V(1) is equivalent to Zap's DebugLevel
```

Now after setting the log level to `default: debug`

I see

```
2024-10-31T01:59:31.138Z	DEBUG	gateway-api	runner/runner.go:176	{"proxy":{"metadata":{"labels":{"gateway.envoyproxy.io/owning-gateway-name":"eg","gateway.envoyproxy.io/owning-gateway-namespace":"default"}},"name":"default/eg","listeners":[{"name":"default/eg/http","address":null,"ports":[{"name":"http-80","protocol":"HTTP","servicePort":80,"containerPort":10080}]}]}}	{"runner": "gateway-api", "infra-ir": "default/eg"}
2024-10-31T01:59:31.138Z	DEBUG	gateway-api	runner/runner.go:187	{"accessLog":{"text":[{"path":"/dev/stdout"}]},"http":[{"name":"default/eg/http","address":"0.0.0.0","port":10080,"metadata":{"kind":"Gateway","name":"eg","namespace":"default","sectionName":"http"},"hostnames":["*"],"routes":[{"name":"httproute/default/backend/rule/0/match/0/www_example_com","hostname":"www.example.com","isHTTP2":false,"pathMatch":{"name":"","prefix":"/","distinct":false},"destination":{"name":"httproute/default/backend/rule/0","settings":[{"weight":1,"protocol":"HTTP","endpoints":[{"host":"10.1.19.7","port":3000}],"addressType":"IP"}]},"metadata":{"kind":"HTTPRoute","name":"backend","namespace":"default"}}],"isHTTP2":false,"path":{"mergeSlashes":true,"escapedSlashesAction":"UnescapeAndRedirect"}}]}	{"runner": "gateway-api", "xds-ir": "default/eg"}
```

Relates to envoyproxy#4505

Signed-off-by: Arko Dasgupta <[email protected]>
(cherry picked from commit e6307f0)
Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit d42915a)
Signed-off-by: Huabing Zhao <[email protected]>
… status (envoyproxy#4592)

fix route status wrong ns

Signed-off-by: Huabing Zhao <[email protected]>
(cherry picked from commit 7285dda)
Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants