-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add standalone deployment doc #4518
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: shawnh2 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4518 +/- ##
==========================================
- Coverage 65.66% 65.64% -0.03%
==========================================
Files 211 211
Lines 31689 31689
==========================================
- Hits 20810 20801 -9
- Misses 9677 9686 +9
Partials 1202 1202 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <[email protected]>
Compile Envoy Gateway binary from project by using command: | ||
|
||
```shell | ||
make build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently, we let users to build envoy-gateway binary from scratch. should we include this binary in release ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even in standalone mode, we should use docker instead of pure binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I think it's fine to use docker to spin up the EG in the documentation.
However, we should include the binaries to the release assets and update the doc to add the binary option. This can be addressed is a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldnt be use make
command here, instead either use GH releases assets https://github.com/envoyproxy/gateway/releases/tag/v1.2.0-rc.1 (if envoy-gateway
is not present, we should consider pushing it), or Docker Image, my vote is for GH releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you build binary, you will need to support all the platforms(e.g. macos, windows), TBH, I think there's a kind of waste?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's 2024, Docker is enough for 99% of the cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are many production environments/server thats are running a server with a manager like systemd that have no docker installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to envoyproxy https://github.com/envoyproxy/envoy/releases/tag/v1.32.0 , imo linux-x86_64
is good enough for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like @zhaohuabing 's idea. we should include eg binary in release, and maybe just for linux only, this can be done as a follow-up.
but for now, using docker to start eg sgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raised #4566 to track the GH release work
wait #4535 |
/retest |
{{% /alert %}} | ||
|
||
Envoy Gateway also supports running in standalone mode. In this mode, you can configure the | ||
Envoy Gateway to use different file provider and infrastructure provider combinations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong opinion , non-blocking - this would be a bit confusing for readers. I suggest removing this and rephrase the standalone mode as the only support combination is the file provider and the host infrastructure.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1393
Release Notes: No