Skip to content

Commit

Permalink
add issue link
Browse files Browse the repository at this point in the history
Signed-off-by: Huabing Zhao <[email protected]>
  • Loading branch information
zhaohuabing committed Nov 1, 2024
1 parent 21fb4f1 commit 1e16d24
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e/tests/oidc.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ func testOIDC(t *testing.T, suite *suite.ConformanceTestSuite) {
// Parse the response body to get the URL where the login page would post the user-entered credentials
if err := oidcClient.ParseLoginForm(res.Body, keyCloakLoginFormID); err != nil {
tlog.Logf(t, "failed to parse login form: %v", err)
// restart the envoy proxy to recover from the error, this is a workaround for the flaky test
// restart the envoy proxy to recover from the error, this is a workaround for the flaky test: https://github.com/envoyproxy/gateway/issues/3898
// TODO: we should investigate the root cause of the flakiness and remove this workaround
proxyLabel := map[string]string{"gateway.envoyproxy.io/owning-gateway-name": "same-namespace"}
err := suite.Client.DeleteAllOf(context.TODO(), &corev1.Pod{}, client.MatchingLabels(proxyLabel), client.InNamespace("envoy-gateway-system"))
Expand Down

0 comments on commit 1e16d24

Please sign in to comment.