Fixing bug causing output of "1 Years ago" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yin-fod! Would you mind adding a spec for this to the demo tests? https://github.com/ello/TimeAgoInWords/blob/master/Demo/DemoTests/TimeAgoInWordsSpec.swift |
| @@ -21,6 +21,7 @@ public struct TimeAgoInWordsStrings { | |||
| static var Day = NSLocalizedString("d", comment:"One day in time") | |||
| static var Days = NSLocalizedString("d", comment:"More than one day in time") | |||
| static var Months = NSLocalizedString("mth", comment:"More than one month in time") | |||
| static var Year = NSLocalizedString("y", comment:"one year in time") | |||
There was a problem hiding this comment.
Not a big deal, but for consistency it would be nice to capitalize "one".
|
Add a spec and we will get this merged 🤘 |
lyzkov
reviewed
Nov 10, 2016
| @@ -38,6 +39,7 @@ public struct TimeAgoInWordsStrings { | |||
| case "day": Day = value | |||
| case "days": Days = value | |||
| case "months": Months = value | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.