Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove autofocusing in the modal #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove autofocusing in the modal #106

wants to merge 2 commits into from

Commits on Dec 11, 2015

  1. Remove autofocusing in the Modal 

    Remove autofocusing on the first focusable element in the modal as this
is not compatible with React’s way of handling autofocus. React doesn’t
add the `autoFocus` prop to DOM elements which `ally.js` is dependent
on.

Reference: facebook/react#3066 (comment)
    jpersson committed Dec 11, 2015
    Configuration menu
    Copy the full SHA
    70c704f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2015

  1. Only add/remove accessibility event handlers when the modal is opened… 

    …/closed
    jpersson committed Dec 13, 2015
    Configuration menu
    Copy the full SHA
    46c9974 View commit details
    Browse the repository at this point in the history