Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion][perf] Memoize low-impact components (D-F) #7637

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[Emotion][perf] Memoize low-impact components (D-F) #7637

wants to merge 7 commits into from

Commits on Mar 29, 2024

  1. [EuiDatePickerRange] Memoize styles 

    + simplify styles array

- not sure I love the extra inline styles always being memoized even if they aren't used, but c'est la vie
    @cee-chen
    cee-chen committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ad8fa0c View commit details
    Browse the repository at this point in the history

  2. [Draggable] Memoize styles

    @cee-chen
    cee-chen committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    62235e4 View commit details
    Browse the repository at this point in the history

  3. [EuiErrorBoundary] Memoize styles

    @cee-chen
    cee-chen committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ab7af6b View commit details
    Browse the repository at this point in the history

  4. [EuiExpression] Memoize styles 

    + remove unnecessary function for styles w/ no theme token

+ inline JSX where possible
    @cee-chen
    cee-chen committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    fea869a View commit details
    Browse the repository at this point in the history

  5. [EuiFacetButton] Memoize + simplify styles 

    - disabled opacity is fairly static and can be DRYed out

- loading spinner: no styles being applied so this isn't necessary
    @cee-chen
    cee-chen committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    25c2914 View commit details
    Browse the repository at this point in the history

  6. [EuiFacetGroup] Memoize styles 

    + remove passed `layout` arg in favor of static definitions

- rewrite vertical vs horizontal gutters utils to be slightly less confusing

+ replace `calc()` with `mathWithUnits()`
    @cee-chen
    cee-chen committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6ddec0c View commit details
    Browse the repository at this point in the history

  7. [EuiFilterGroup] Memoize styles 

    + prefer inline JSX
    @cee-chen
    cee-chen committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ea2b89d View commit details
    Browse the repository at this point in the history