Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Badge typing for label #2091

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fixed Badge typing for label #2091

merged 2 commits into from
Sep 20, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Sep 19, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Type shown in the documentation for the label prop inside Badge component was wrong. It can be either string or number based on the mode (string for contextual, number for notification)

Additional context
The typing has been slightly modified for notification mode to use "" in case of not wanting to display content inside, instead of having to work with a possibly undefined value, allowing label to have a default value of "" just like it is done in, for example Button component. Changing the typing of the notification mode in the code was not required

@Mil4n0r Mil4n0r changed the title Fixed Badge typing for 'label' Fixed Badge typing for label Sep 19, 2024
@Mil4n0r Mil4n0r marked this pull request as ready for review September 20, 2024 10:38
@GomezIvann GomezIvann merged commit 5df2a5e into master Sep 20, 2024
1 check passed
@GomezIvann GomezIvann deleted the Mil4n0r/fix_badge_typing branch September 20, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants