Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem in ResultsetTable when sortValue is missing #2082

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Aug 22, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
SortValue must take displayValue instead if it is undefined. After changing the structure adding the "cells" item, this is not working.

@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Aug 22, 2024

I will be adding interaction tests for this scenario to prevent it from happening again.

@Mil4n0r Mil4n0r marked this pull request as ready for review August 22, 2024 06:50
@jsuarezgonz jsuarezgonz self-assigned this Aug 23, 2024
Copy link
Collaborator

@jsuarezgonz jsuarezgonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a functional test to check that the columns are correctly sorted according to 'displayValue' when 'sortValue' is undefined

@jsuarezgonz jsuarezgonz merged commit ff31c60 into master Aug 23, 2024
4 checks passed
@jsuarezgonz jsuarezgonz deleted the Mil4n0r/fix_resultset_table_sort branch August 23, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants