Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data visualization page #2065

Merged
merged 8 commits into from
Aug 9, 2024
Merged

New Data visualization page #2065

merged 8 commits into from
Aug 9, 2024

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Aug 6, 2024 •
edited
Loading

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Adding the new Data Visualization principle page while also removing the bar chart documentation.

Closes #2069 #2070

@GomezIvann GomezIvann linked an issue Aug 6, 2024 that may be closed by this pull request
Create the new Data Visualization principles page #2070
Closed
@GomezIvann GomezIvann marked this pull request as ready for review August 7, 2024 08:46
@Mil4n0r Mil4n0r self-requested a review August 7, 2024 10:04
Mil4n0r
Mil4n0r requested changes Aug 8, 2024
View reviewed changes
apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx Outdated Show resolved Hide resolved
apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx Outdated Show resolved Hide resolved
apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx Outdated Show resolved Hide resolved
apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx Outdated Show resolved Hide resolved
apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx Outdated Show resolved Hide resolved
apps/website/screens/components/button/usage/ButtonUsagePage.tsx Outdated Show resolved Hide resolved
apps/website/screens/principles/data-visualization/DataVisualizationPage.tsx Show resolved Hide resolved
@Mil4n0r Mil4n0r merged commit f8ea611 into master Aug 9, 2024
3 of 4 checks passed
@Mil4n0r Mil4n0r deleted the gomezivann/data-visualization branch August 9, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mil4n0r Mil4n0r Mil4n0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@GomezIvann @Mil4n0r