Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Grid component #2056

Merged
merged 27 commits into from
Aug 16, 2024
Merged

Data Grid component #2056

merged 27 commits into from
Aug 16, 2024

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Jul 25, 2024 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
A clear description of the purpose of the change. Applicable in case this change is not linked to an issue.

Description
A clear and concise description of the change.

Screenshots
If applicable, add screenshots to help explain your change request.

Additional context
Add any other context about the change here.

Closes #issue-number

@Mil4n0r Mil4n0r self-requested a review July 25, 2024 11:24
Mil4n0r
Mil4n0r requested changes Jul 31, 2024
View reviewed changes
packages/lib/src/data-grid/utils.tsx Show resolved Hide resolved
packages/lib/src/data-grid/utils.tsx Outdated Show resolved Hide resolved
packages/lib/src/data-grid/DataGrid.tsx Outdated Show resolved Hide resolved
packages/lib/src/data-grid/DataGrid.tsx Outdated Show resolved Hide resolved
packages/lib/src/data-grid/DataGrid.tsx Show resolved Hide resolved
packages/lib/src/data-grid/DataGrid.tsx Show resolved Hide resolved
packages/lib/src/data-grid/DataGrid.tsx Show resolved Hide resolved
packages/lib/src/data-grid/utils.tsx Show resolved Hide resolved
Mil4n0r
Mil4n0r requested changes Aug 7, 2024
View reviewed changes
packages/lib/src/data-grid/types.ts Show resolved Hide resolved
packages/lib/src/data-grid/types.ts Outdated Show resolved Hide resolved
packages/lib/src/data-grid/utils.tsx Outdated Show resolved Hide resolved
apps/website/screens/theme-generator/components/previews/DataGrid.tsx Show resolved Hide resolved
Mil4n0r
Mil4n0r requested changes Aug 13, 2024
View reviewed changes
packages/lib/src/data-grid/utils.tsx Outdated Show resolved Hide resolved
packages/lib/src/data-grid/DataGrid.tsx Outdated Show resolved Hide resolved
packages/lib/src/data-grid/DataGrid.tsx Show resolved Hide resolved
packages/lib/src/common/variables.ts Show resolved Hide resolved
@Jialecl Jialecl marked this pull request as ready for review August 13, 2024 12:25
@Mil4n0r Mil4n0r self-requested a review August 16, 2024 08:42
@Mil4n0r Mil4n0r merged commit c3b3314 into master Aug 16, 2024
4 checks passed
@Mil4n0r Mil4n0r deleted the jialecl/datagrid branch August 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mil4n0r Mil4n0r Mil4n0r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jialecl @Mil4n0r