-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DxcLink
border radius
#2039
Conversation
I have yet to ask for the specs image with the 2px padding added. |
…y/halstack-react into Mil4n0r/link_border-radius
…y/halstack-react into Mil4n0r/link_border-radius
All images have been updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…o Mil4n0r/link_border-radius
…y/halstack-react into Mil4n0r/link_border-radius
I missed that, but I agree with you that it is too tall. Using 100% line-height for the anchor seems to look just like in the images. |
Checklist
(Check off all the items before submitting)
/lib
directory./website
as needed.Description
For consistency purposes, the border-radius of the Link component is 2px and we want to update it to 4px. This is its value in most of our components.
Additional context
Even though it was listed as 2px, the images used were using
border-radius: 4px
internally. That is why it is only required to change the first image in the Specifications tab.Closes #1719