Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DxcLink border radius #2039

Merged
merged 20 commits into from
Aug 9, 2024
Merged

Fix DxcLink border radius #2039

merged 20 commits into from
Aug 9, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Jul 12, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
For consistency purposes, the border-radius of the Link component is 2px and we want to update it to 4px. This is its value in most of our components.

Additional context
Even though it was listed as 2px, the images used were using border-radius: 4px internally. That is why it is only required to change the first image in the Specifications tab.

Closes #1719

@Mil4n0r Mil4n0r changed the title Mil4n0r/link border radius Fix boorder radius Jul 12, 2024
@Mil4n0r Mil4n0r changed the title Fix boorder radius Fix border radius Jul 12, 2024
packages/lib/src/link/Link.tsx Outdated Show resolved Hide resolved
@Mil4n0r Mil4n0r changed the title Fix border radius Fix DxcLink border radius Jul 23, 2024
@Mil4n0r Mil4n0r marked this pull request as draft July 23, 2024 13:19
@Mil4n0r Mil4n0r requested a review from GomezIvann July 24, 2024 10:25
@Mil4n0r Mil4n0r marked this pull request as ready for review July 24, 2024 10:25
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Jul 24, 2024

I have yet to ask for the specs image with the 2px padding added.

@Mil4n0r Mil4n0r marked this pull request as draft July 24, 2024 12:30
@Mil4n0r Mil4n0r marked this pull request as ready for review July 25, 2024 06:23
…y/halstack-react into Mil4n0r/link_border-radius
@Mil4n0r Mil4n0r marked this pull request as draft July 25, 2024 07:09
@Mil4n0r Mil4n0r marked this pull request as ready for review July 25, 2024 07:56
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Jul 25, 2024

All images have been updated.

@GomezIvann GomezIvann self-assigned this Jul 31, 2024
@Mil4n0r Mil4n0r marked this pull request as draft August 1, 2024 08:30
@Mil4n0r Mil4n0r marked this pull request as ready for review August 1, 2024 12:54
Copy link
Collaborator

@GomezIvann GomezIvann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, comparing the component with the designs and the specs images I still think the component is too tall. Maybe we need to adjust this by updating the line-height, what do you think? Maybe we need Lara or Irene's help.

image

packages/lib/src/link/Link.tsx Outdated Show resolved Hide resolved
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Aug 8, 2024

One comment, comparing the component with the designs and the specs images I still think the component is too tall. Maybe we need to adjust this by updating the line-height, what do you think? Maybe we need Lara or Irene's help.

image

I missed that, but I agree with you that it is too tall. Using 100% line-height for the anchor seems to look just like in the images.

@GomezIvann GomezIvann merged commit 75cb2b9 into master Aug 9, 2024
4 checks passed
@GomezIvann GomezIvann deleted the Mil4n0r/link_border-radius branch August 9, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Link component border-radius
2 participants