Add test to check parameters for errors and httpErrorCodes #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuiltyDolphin
requested changes
Feb 20, 2024
broken-site-reporting/README.md
Outdated
| @@ -25,6 +25,8 @@ Test suite specific fields: | |||
| - `model` - string - name of the device model (native apps only) | |||
| - `os` - string - operating system name (native apps only) | |||
| - `gpcEnabled` - boolean - if GPC is enabled or not (native apps only) - GPC can be disabled by user or by remote config | |||
| - `errorDescription` - string - optional field containing a description from an error generated by failed page load | |||
| - `httpStatusCode` - int - optional field containing the HTTP status code returned by the page load | |||
There was a problem hiding this comment.
There can be multiple codes, so make this httpStatusCodes and an array
E.g., for an array [304, 200], on Firefox we'd see this sent as 304%2C200 (can you add that as a test case please?)
If we want to keep the naming consistent, we could use httpErrorCodes here
broken-site-reporting/README.md
Outdated
| @@ -25,6 +25,8 @@ Test suite specific fields: | |||
| - `model` - string - name of the device model (native apps only) | |||
| - `os` - string - operating system name (native apps only) | |||
| - `gpcEnabled` - boolean - if GPC is enabled or not (native apps only) - GPC can be disabled by user or by remote config | |||
| - `errorDescription` - string - optional field containing a description from an error generated by failed page load | |||
There was a problem hiding this comment.
Like below, so name as errorDescriptions
Test case: ["net::ERR_NAME_NOT_RESOLVED","net::ERR_ABORTED"] should become %5B%22net%3A%3AERR_NAME_NOT_RESOLVED%22%2C%22net%3A%3AERR_ABORTED%22%5D
…privacy-reference-tests into brad/breakage-report-updates
|
@SlayterDev I added a couple of minor adjustments to the type phrasing. LGTM! |
GuiltyDolphin
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the breakage report tests which checks for the presence of
errorDescriptionsandhttpErrorCodes. The PR also skips some tests on the macOS platform which aren't currently supported.