-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to check parameters for errors and httpErrorCodes #125
Conversation
broken-site-reporting/README.md
Outdated
@@ -25,6 +25,8 @@ Test suite specific fields: | |||
- `model` - string - name of the device model (native apps only) | |||
- `os` - string - operating system name (native apps only) | |||
- `gpcEnabled` - boolean - if GPC is enabled or not (native apps only) - GPC can be disabled by user or by remote config | |||
- `errorDescription` - string - optional field containing a description from an error generated by failed page load | |||
- `httpStatusCode` - int - optional field containing the HTTP status code returned by the page load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There can be multiple codes, so make this httpStatusCodes
and an array
E.g., for an array [304, 200], on Firefox we'd see this sent as 304%2C200
(can you add that as a test case please?)
If we want to keep the naming consistent, we could use httpErrorCodes
here
broken-site-reporting/README.md
Outdated
@@ -25,6 +25,8 @@ Test suite specific fields: | |||
- `model` - string - name of the device model (native apps only) | |||
- `os` - string - operating system name (native apps only) | |||
- `gpcEnabled` - boolean - if GPC is enabled or not (native apps only) - GPC can be disabled by user or by remote config | |||
- `errorDescription` - string - optional field containing a description from an error generated by failed page load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like below, so name as errorDescriptions
Test case: ["net::ERR_NAME_NOT_RESOLVED","net::ERR_ABORTED"]
should become %5B%22net%3A%3AERR_NAME_NOT_RESOLVED%22%2C%22net%3A%3AERR_ABORTED%22%5D
…privacy-reference-tests into brad/breakage-report-updates
@SlayterDev I added a couple of minor adjustments to the type phrasing. LGTM! |
This PR adds a test for the breakage report tests which checks for the presence of
errorDescriptions
andhttpErrorCodes
. The PR also skips some tests on the macOS platform which aren't currently supported.