-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AI Chat toolbar #3470
base: main
Are you sure you want to change the base?
Add AI Chat toolbar #3470
Conversation
…icon # Conflicts: # DuckDuckGo/Preferences/View/PreferencesViewController.swift
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bunn Functionality-wise, it looks excellent 👍🏼 .
I’ve added a comment around tests. What do you think of implementing the suggestions before merging?
@@ -95,9 +88,44 @@ class AIChatMenuConfigurationTests: XCTestCase { | |||
} | |||
cancellable.cancel() | |||
} | |||
|
|||
func testShouldNotDisplayToolbarShortcutWhenDisabled() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have the following tests:
- We do not display the toolbar shortcut when the remote flag is true, but the storage is false
- We do not display the toolbar when the remote setting is false, and the storage is true
- The same for the shortcut
The same goes for showing the toolbar and shortcut. We should be explicit that the remote settings flags need to be false if you take a look at the test now, it seems that you only need the storage flag.
Task/Issue URL: https://app.asana.com/0/1204167627774280/1208607376873996/f
Tech Design URL:
CC:
Description:
Add AI Chat toolbar icon onboarding flow
Steps to Test This PR: