Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pete/freemium pir manual removal links #3466

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Oct 28, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208619435900636/f
FE PR: https://dub.duckduckgo.com/duckduckgo/static-pages/pull/1012

Description: Adds a manual removal link to each Freemium PIR result record view

Note: The frontend UI is in flux. However, the native work can be tested

Test Prerequisites

  1. Set yourself as an internal user via Debug menu → Set Internal User State
  2. Disable/Signout of Privacy Pro via Settings menu → PP → Remove from this device
  3. Select Debug menu → Freemium -> Enroll into Experiment
  4. Select Debug menu → Freemium -> Reset all Freemium State
  5. Set the custom frontend UI URL via Debug menu → Personal Information Removal → Web UI → Set Custom URL. Enter https://abrown.duckduckgo.com/dbp
  6. Use the custom frontend UI URL via Debug menu → Personal Information Removal → Web UI → Use Custom URL
    Relaunch the browser

Steps to test this PR:

  1. Open Freemium PIR (via the meatball overflow menu or new tab banner)
  2. Perform a scan
  3. Wait until results appear
  4. Click on a result to open the result modal
  5. Ensure you see some UI (exact UI design in flux) at the top which includes a link to enable the user to manually remove the record
  6. Click the link and ensure it opens an optout page on the relevant broker
Screenshot 2024-10-29 at 10 39 39

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@aataraxiaa aataraxiaa marked this pull request as ready for review October 29, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant