Refactor automatic update flow to use custom Sparkle user driver #3274
+1,114
−526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @quanganhdo and the rest of your teammates on |
|
quanganhdo
changed the title
This was referenced Sep 13, 2024
Closed
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
2 times, most recently
from
1a1d4e6
to
ccfe27b
Compare
tomasstrba
reviewed
Sep 18, 2024
tomasstrba
reviewed
Sep 18, 2024
There was a problem hiding this comment.
@quanganhdo, after installation of the build number 261, it says the app is up to date which is not expected. Am I missing something? I'm currently at the coffee shop with a low connection or maybe the phased rollout is the reason?
Another minor thing is the empty box in the release notes which I suppose is caused by empty release notes in the appcast. Just flagging it in case not.
|
The test appcast pointed to I've removed that channel from the file. Update should show up now (along with the release note). |
tomasstrba
approved these changes
Sep 19, 2024
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
from
ccfe27b
to
3f91338
Compare
1 task
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
from
7884731
to
0fcc157
Compare
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
from
0fcc157
to
7166bc1
Compare
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
from
7166bc1
to
4130eff
Compare
1 task
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
from
4130eff
to
bdc7a75
Compare
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
2 times, most recently
from
3ea3c66
to
3be08ff
Compare
…'s due based on SULastCheckTime
…RL (to be reverted) This reverts commit e1deee3.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208183525704010/f Tech Design URL: CC: Figma: https://www.figma.com/design/vDBpSFDzW0eN7nwpS95gju/macOS-update-process?node-id=2359-52971&t=KnvIdm2f7PRjNwfK-4 **Description**: **Steps to test this PR**: 1. Change the appcast URL to an invalid URL to test the error state 2. Play with different update options to see if update works <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Task/Issue URL: https://app.asana.com/0/414235014887631/1208183525704010/f Tech Design URL: CC: **Description**: Addresses Ship Review comments. **Steps to test this PR**: 1. Just copy & icon updates so this should be good if CI passes. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
quanganhdo
force-pushed
the
anh/refactor/sparkle-user-driver
branch
from
4b88f38
to
fcfef66
Compare
tomasstrba
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Final LGTM! ✅
@quanganhdo, good job! 👏 This is a great improvement, I appreciate you dived into it and found a better solution. 🏅
As we discussed during our 1:1 today, one final test with review builds would be awesome, but it's not required since we'll be testing it during the internal release phase next week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1208183525704010/f
Tech Design URL:
CC:
Description:
Refactors automatic update flow to use a custom Sparkle user driver.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation