Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Config feature to control ad attribution reporting #3506

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Oct 30, 2024

Task/Issue URL: https://app.asana.com/0/0/1208638248015576/f
Tech Design URL:
CC:

Description:

Adds the ability to use remote config to control AdAttributionPixelReporter and whether the token is added as parameter.

Steps to test this PR:
⚠️ Device is required to fully test this change. Attribution is not available on simulator.

  1. Modify remote config URL to https://www.jsonblob.com/api/1301173210350215168. Put app in the background and reactivate.
  2. Verify attribution pixel is fired including token parameter.
  3. Remove the app, change includeToken setting to false in the linked configuration json file or remove setting object completely, verify attribution pixel is fired without token parameter.
  4. Turn off the feature in configuration json, verify no attribution pixel is fired.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 marked this pull request as ready for review October 30, 2024 14:31
@dus7 dus7 requested a review from samsymons October 30, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant