Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN clean-up #3502

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

VPN clean-up #3502

wants to merge 1 commit into from

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1207603085593419/1208654487861283/f
Tech Design URL:
CC:

Description:

This PR cleans up some VPN code, namely some pixels from events that no longer exist.

Steps to test this PR:

  1. Smoke test the VPN

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant