Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniel/dp.open.new.tab #3490

Closed
wants to merge 75 commits into from
Closed

Daniel/dp.open.new.tab #3490

wants to merge 75 commits into from

Conversation

afterxleep
Copy link
Collaborator

Task/Issue URL:
Tech Design URL:
CC:

Description:

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep
Open DuckPlayer Videos in New Tab #1
6fc8a2e
@afterxleep
Handle JS Based navigation
5c75a0c
@afterxleep
Add Setting
425ec8f
@afterxleep
Added Unit tests
0fef7ec
@afterxleep
Added Feature Flag
e3510f0
@afterxleep
Merge branch 'main' into daniel/dp.new.tab.base
fe9c60c
@afterxleep
Correct Feature Flag
20ea632
@afterxleep
Use Local navigationType instead
5212141
@afterxleep
Fix unit tests
c63c339
@afterxleep
Adding Pixels
5dd2f22
@afterxleep
Only trigger JS Navigation if not WatchInYoutube
44bd50e
@afterxleep
Default to true
d59d700
@afterxleep
Updated DuckPlayer logic to base on URL changes
b42f186
@afterxleep
Updated Navigation
c3d184f
@afterxleep
Fixes back navigation issue
c0098ae
@afterxleep
Improved Duck Navigation Handling
5ee35b5
@afterxleep
Add Documentation
da66c1f
@afterxleep
Added tests for URL navigation
54b9d6f
@afterxleep
Improve back Navigation
f12cdb1
@afterxleep
Added backForward navigation
81ccbd4
@afterxleep
Handler optimizations
1e61ea7
@afterxleep
Fixed OpenInYoutube navigation and added test
1c39641
@afterxleep
Fixed age restricted video
e0db486
@afterxleep
Make back-forward navigation safe
8186c52
@afterxleep
Remove DuckPlayer Experiment logic
670f24d
@afterxleep
Remove Experiment from tests
dd37f16
@afterxleep
Update DuckPlayer load timer
55d1a9d
@afterxleep
Moves the stopLoading to happen after the delay
52ca138
@afterxleep
Reduce Request time
ccda462
@afterxleep
Properly handle Youtube Player internal links
db8970c
@afterxleep
Clean up code
4b0d5e3
@afterxleep
Added some comments
b1ca525
@afterxleep
More Docs
54ce418
@afterxleep
Additional docs
f461713
@afterxleep
Improved way to detect a new Tab
e9e7872
@afterxleep
Update Feature Flags
88fe9c6
@afterxleep
Updated tests & Simplified navigation
5d38885
@afterxleep
Optimizations
2c9ea63
@afterxleep
Reverted BackNavigationHandler
46a6abf
@afterxleep
Some Fixes
fd2136c
@afterxleep
Navigation handling should only use the main frame
e5da346
@afterxleep
Use old Javascript Handler
2633623
@afterxleep
Fix backForward Navigation Issues
48b7e8f
@afterxleep
Add delay on Navigation Cancellation
303495c
@afterxleep
Fix navigation issue
c9315f5
@afterxleep
Clean up
2f23671
@afterxleep
Improved new tab navigation
f6040af
@afterxleep
Throttle Javascript Navigation events
c717a41
@afterxleep
Limit Redirections and loading to ONE
23050f8
@afterxleep
Proper backnavigation from OpenInYoutube pages
af70bf7
@afterxleep
More nav updates
317c27b
@afterxleep
Never cancel navigation if Duckplayer != enabled
11090a0
@afterxleep
Update pixels
a42d70b
@afterxleep
Reset allowFirstVideo after page loads
9223a50
@afterxleep
Revert "Merge branch 'main' into daniel/dp.new.tab.base"
261fd3b 
This reverts commit 67a118a, reversing
changes made to c390464.
@afterxleep
Merge branch 'main' into daniel/dp.open.new.tab
72d0723 
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/TabViewController.swift
@afterxleep afterxleep changed the base branch from main to 07-19-bump_privacy-dashboard_to_4.3.1 October 27, 2024 12:54
@afterxleep afterxleep changed the base branch from 07-19-bump_privacy-dashboard_to_4.3.1 to main October 27, 2024 12:54
@github-actions GitHub Actions
Copy link

Fails
🚫 Please, don't forget to add a link to the internal task
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 72d0723

@afterxleep afterxleep closed this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@afterxleep