Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Dock Onboarding feature flag #3476

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

alessandroboron
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1206329551987282/1208577512136639/f

Description:

Add a feature flag used to show Add to Dock during the onboarding flow.
Note that the feature will be available only for iPhone

Steps to test this PR:

Prerequisites:

Add return VariantIOS(name: "mu", weight: 1, isIncluded: When.always, features: [.newOnboardingIntro, .contextualDaxDialogs]) in DefaultVariantManager -> selectVariant() line 156.

Scenario 1 — When the End of Journey Dialog is presented from NTP and Add to Dock flag is enabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. Login as internal user.
  4. In the Debug menu -> New Onboarding -> enable Onboarding Add to Dock local setting.
  5. Progress with the contextual onboarding and use the fire button till seeing end of journey dialog.
  6. Ensure the Console log prints “Present Final Dialog with Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Scenario 2 — When the End of Journey Dialog is presented from NTP and Add to Dock flag is disabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. In the Debug menu -> New Onboarding -> disable Onboarding Add to Dock local setting.
  4. Progress with the contextual onboarding and use the fire button till seeing end of journey dialog.
  5. Ensure the Console log prints “Present Final Dialog without Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Scenario 3 — When the End of Journey Dialog is presented from in context and Add to Dock flag is enabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. Login as internal user.
  4. In the Debug menu -> New Onboarding -> enable Onboarding Add to Dock local setting.
  5. Progress with the contextual onboarding tille the fire dialog. Don’t use the fire dialog.
  6. Navigate to another website and wait for the contextual end of journey dialog is presented.
  7. Ensure the Console log prints “Present Contextual Final Dialog with Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Scenario 4 — When the End of Journey Dialog is presented from in context and Add to Dock flag is disabled then log Add to Dock

  1. Complete onboarding intro.
  2. Wait for Contextual Dax dialogs to appear.
  3. Login as internal user.
  4. In the Debug menu -> New Onboarding -> enable Onboarding Add to Dock local setting.
  5. Progress with the contextual onboarding tille the fire dialog. Don’t use the fire dialog.
  6. Navigate to another website and wait for the contextual end of journey dialog is presented.
  7. Ensure the Console log prints “Present Contextual Final Dialog without Add To Dock updates” (you need to enable subsystem in the metadata filter and set it to Onboarding)

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! all works as expected

@alessandroboron alessandroboron merged commit fb6a53f into main Oct 29, 2024
13 checks passed
@alessandroboron alessandroboron deleted the alessandro/add-to-dock-feature-flag branch October 29, 2024 10:34
samsymons added a commit that referenced this pull request Oct 30, 2024
* main:
  adding impression pixels for duckplayer in landscape mode (#3493)
  Update autoconsent to v10.17.0 (#3504)
  Onboarding Add to Dock Tutorial (#3482)
  Blind attempt to fix Omnibar-related crash (#3500)
  Add to Dock Localised strings (#3494)
  Add to Dock Onboarding feature flag (#3476)
  Remove HomePageViewController code (#3454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants