Add to Dock Onboarding feature flag #3476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208577512136639/f
Description:
Add a feature flag used to show Add to Dock during the onboarding flow.
Note that the feature will be available only for iPhone
Steps to test this PR:
Prerequisites:
Add
return VariantIOS(name: "mu", weight: 1, isIncluded: When.always, features: [.newOnboardingIntro, .contextualDaxDialogs])
inDefaultVariantManager -> selectVariant()
line 156.Scenario 1 — When the End of Journey Dialog is presented from NTP and Add to Dock flag is enabled then log Add to Dock
Scenario 2 — When the End of Journey Dialog is presented from NTP and Add to Dock flag is disabled then log Add to Dock
Scenario 3 — When the End of Journey Dialog is presented from in context and Add to Dock flag is enabled then log Add to Dock
Scenario 4 — When the End of Journey Dialog is presented from in context and Add to Dock flag is disabled then log Add to Dock
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template