Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form Analyzer] Add 'guest' to signup regex in analyser #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dbajpeyi
Copy link
Collaborator

@dbajpeyi dbajpeyi commented Oct 30, 2024

Reviewer: @GioSensation
Asana: https://app.asana.com/0/1205996472158114/1208414891646031/f

Description

On jcrew.com, the guest checkout form is treated as a login one. This is because the Have an account? Sign in text seems to score it on the login side, however multiple attributes with guest or Guest in the string and attributes are ignored. Such checkout forms are used in plenty of shopping sites, so it's likely that guest should be scored rather as a signup.

Adding guest to signup regex should work. I am also adding it to conservative one, I think it's a pretty strong indicator for signup.

image

Steps to test

  1. Go to Jcrew.com
  2. Add a product to the bag, and click on checkout (from the dropdown)
  3. In the bag, go to checkout and click on "Continue as guest"
  4. Guest form should have email protection showing:
Screenshot 2024-10-30 at 17 35 22

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/jcrew-guest-email branch from c3fabc9 to 3b297eb Compare October 30, 2024 16:31
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/jcrew-guest-email branch from 3b297eb to 7576702 Compare October 30, 2024 16:31
@dbajpeyi dbajpeyi marked this pull request as ready for review October 30, 2024 16:36
@dbajpeyi dbajpeyi changed the title fix: add 'guest' to signup regex in analyser [Form Analyzer] Add 'guest' to signup regex in analyser Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant