[Form Analyzer] Add 'guest' to signup regex in analyser #694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1205996472158114/1208414891646031/f
Description
On jcrew.com, the guest checkout form is treated as a login one. This is because the
Have an account? Sign in
text seems to score it on the login side, however multiple attributes withguest
orGuest
in the string and attributes are ignored. Such checkout forms are used in plenty of shopping sites, so it's likely thatguest
should be scored rather as a signup.Adding
guest
to signup regex should work. I am also adding it to conservative one, I think it's a pretty strong indicator for signup.Steps to test