Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

favorites drag and drop #1150

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

favorites drag and drop #1150

wants to merge 26 commits into from

Conversation

shakyShane
Copy link
Contributor

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 21, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane mentioned this pull request Oct 21, 2024
Merged
10 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

[Beta] Generated file diff

Time updated: Mon, 28 Oct 2024 08:28:57 GMT

Android 
    - android/pages/duckplayer/js/index.js

File has changed

Integration 
    - integration/pages/duckplayer/js/index.js
  • integration/pages/example/js/index.js
  • integration/pages/new-tab/company-icons/i.svg
  • integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js
  • integration/pages/onboarding/js/index.js
  • integration/pages/release-notes/js/index.js
  • integration/pages/special-error/js/index.js

File has changed

Windows 
    - windows/pages/duckplayer/js/index.js
  • windows/pages/new-tab/company-icons/i.svg
  • windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js
  • windows/pages/onboarding/js/index.js

File has changed

Apple 
    - dist/pages/duckplayer/index.html
  • dist/pages/duckplayer/js/index.js
  • dist/pages/onboarding/js/index.js
  • dist/pages/release-notes/js/index.js
  • dist/pages/special-error/index.html
  • dist/pages/special-error/js/index.js

File has changed

New Files 
    - integration/pages/new-tab/letters/a.svg
  • integration/pages/new-tab/letters/b.svg
  • integration/pages/new-tab/letters/c.svg
  • integration/pages/new-tab/letters/d.svg
  • integration/pages/new-tab/letters/e.svg
  • integration/pages/new-tab/letters/f.svg
  • integration/pages/new-tab/letters/g.svg
  • integration/pages/new-tab/letters/h.svg
  • integration/pages/new-tab/letters/i.svg
  • integration/pages/new-tab/letters/j.svg
  • integration/pages/new-tab/letters/k.svg
  • integration/pages/new-tab/letters/l.svg
  • integration/pages/new-tab/letters/m.svg
  • integration/pages/new-tab/letters/n.svg
  • integration/pages/new-tab/letters/o.svg
  • integration/pages/new-tab/letters/p.svg
  • integration/pages/new-tab/letters/q.svg
  • integration/pages/new-tab/letters/r.svg
  • integration/pages/new-tab/letters/s.svg
  • integration/pages/new-tab/letters/t.svg
  • integration/pages/new-tab/letters/u.svg
  • integration/pages/new-tab/letters/v.svg
  • integration/pages/new-tab/letters/w.svg
  • integration/pages/new-tab/letters/x.svg
  • integration/pages/new-tab/letters/y.svg
  • integration/pages/new-tab/letters/z.svg
  • windows/pages/new-tab/letters/a.svg
  • windows/pages/new-tab/letters/b.svg
  • windows/pages/new-tab/letters/c.svg
  • windows/pages/new-tab/letters/d.svg
  • windows/pages/new-tab/letters/e.svg
  • windows/pages/new-tab/letters/f.svg
  • windows/pages/new-tab/letters/g.svg
  • windows/pages/new-tab/letters/h.svg
  • windows/pages/new-tab/letters/i.svg
  • windows/pages/new-tab/letters/j.svg
  • windows/pages/new-tab/letters/k.svg
  • windows/pages/new-tab/letters/l.svg
  • windows/pages/new-tab/letters/m.svg
  • windows/pages/new-tab/letters/n.svg
  • windows/pages/new-tab/letters/o.svg
  • windows/pages/new-tab/letters/p.svg
  • windows/pages/new-tab/letters/q.svg
  • windows/pages/new-tab/letters/r.svg
  • windows/pages/new-tab/letters/s.svg
  • windows/pages/new-tab/letters/t.svg
  • windows/pages/new-tab/letters/u.svg
  • windows/pages/new-tab/letters/v.svg
  • windows/pages/new-tab/letters/w.svg
  • windows/pages/new-tab/letters/x.svg
  • windows/pages/new-tab/letters/y.svg
  • windows/pages/new-tab/letters/z.svg

❌ File only exists in new changeset

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane changed the base branch from stats_keyboard_support to 10-21-ntp_customizer_button October 21, 2024 15:16
@shakyShane shakyShane mentioned this pull request Oct 21, 2024
Merged
8 tasks
@shakyShane shakyShane marked this pull request as ready for review October 21, 2024 15:43
@shakyShane shakyShane requested review from mgurgel and a team as code owners October 21, 2024 15:43
@shakyShane shakyShane marked this pull request as draft October 21, 2024 15:44
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit a1b218c
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/671f4b0f144b1b0008263c30
😎 Deploy Preview https://deploy-preview-1150--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 2 times, most recently from 91e2b7f to 0465631 Compare October 23, 2024 11:59
Base automatically changed from 10-21-ntp_customizer_button to main October 23, 2024 18:47
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 3 times, most recently from eae4dc2 to 994391c Compare October 24, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgurgel mgurgel Awaiting requested review from mgurgel mgurgel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shakyShane