Skip to content
This repository has been archived by the owner on Nov 19, 2021. It is now read-only.

Live Edit Page V2 #964

Open
wants to merge 13 commits into
base: dev-ia-pages
Choose a base branch
from
Open

Live Edit Page V2 #964

wants to merge 13 commits into from

Conversation

alohaas
Copy link
Contributor

@alohaas alohaas commented Oct 1, 2015

Proposed Improvements:

  • Reorder IA metadata fields
  • Update button styles
  • Remove 'live' fields and set the value of the 'editable' fields to the 'live' value
  • Refactor the edit/done workflow
  • Adjust styles to make the page more readable
  • Differentiate 'name' and 'dev_milestones' at the top of the page

Screenshot: Basic state
screenshot 2015-10-15 15 29 11
Screenshot: Title text hover & focus state
screenshot 2015-10-15 15 29 28
Screenshot: Edited state - edited fields appear $gold. Description textarea also shows the hover state for edited inputs.
screenshot 2015-10-15 15 30 29

@abeyang
Copy link

abeyang commented Oct 15, 2015

Looks good -- much better than what it was like before! 👍

@MariagraziaAlastra
Copy link
Member

Hey @alohaas, I've been playing a bit with this and it looks really good!
Probably not going to be deployed on monday because I want to test it a bit better, but I'm quite sure it'll be released by the end of next week. :)

@alohaas
Copy link
Contributor Author

alohaas commented Oct 26, 2015

@MariagraziaAlastra Thanks! Let me know if you need anything else :)

@MariagraziaAlastra
Copy link
Member

@alohaas Apologies for my late reply!
Anyway I was testing your PR a little bit more in depth and I noticed that after I save my changes and I reload the page (and click again on the edit button) I don't see them anymore. I just see the live value for every field, even though if I go to the commit page I can see that my changes were saved.

Would it be possible to display the edited values when you reload the page as well, and maybe highlight them too?
No rush though!

@alohaas
Copy link
Contributor Author

alohaas commented Nov 10, 2015

Hmm, I thought I did that, but maybe I never committed the changes!
Let me look into it @MariagraziaAlastra

@MariagraziaAlastra
Copy link
Member

Thanks @alohaas!

@russellholt
Copy link
Contributor

would be nice to get this one done.

@alohaas
Copy link
Contributor Author

alohaas commented Dec 14, 2015

I can put this on the list for this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants