Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include www.youtube.com as Youtube host #1028

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Oct 22, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1204099484721401/1208593005609709/f
iOS PR: duckduckgo/iOS#3455
macOS PR: duckduckgo/macos-browser#3434
What kind of version bump will this require?: Minor

Description:
We were missing www.youtube.com as a valid host for Youtube.

@afterxleep afterxleep requested a review from Bunn October 22, 2024 08:20
@shakyShane shakyShane mentioned this pull request Oct 29, 2024
6 tasks
shakyShane and others added 4 commits October 29, 2024 17:02
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
-->

Please review the release process for BrowserServicesKit
[here](https://app.asana.com/0/1200194497630846/1200837094583426).

**Required**:

Task/Issue URL: 
iOS PR: 
macOS PR: 
What kind of version bump will this require?: Major/Minor/Patch

**Optional**:

Tech Design URL:
CC:

**Description**:

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

**Steps to test this PR**:
1.
1.

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**OS Testing**:

* [ ] iOS 14
* [ ] iOS 15
* [ ] iOS 16
* [ ] macOS 10.15
* [ ] macOS 11
* [ ] macOS 12

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)

Co-authored-by: Shane Osbourne <[email protected]>
Task/Issue URL:  https://app.asana.com/0/0/1208077416568652/f
iOS PR: duckduckgo/iOS#3492
macOS PR:  duckduckgo/macos-browser#3415
What kind of version bump will this require?: Minor

**Description**: Updates C-S-S and adds privacy feature
Please review the release process for BrowserServicesKit
[here](https://app.asana.com/0/1200194497630846/1200837094583426).

**Required**:

Task/Issue URL:
https://app.asana.com/0/1108686900785972/1208264562025859/f
iOS PR: duckduckgo/iOS#3488
macOS PR: duckduckgo/macos-browser#3458
What kind of version bump will this require?: Minor

**Description**:
Store and keep in sync the subscription access token for the
duckduckgo.com domain cookie. For the implementation guidelines please
see description of the linked task.

**Steps to test this PR**:
See platform PRs


**OS Testing**:

* [ ] iOS 14
* [ ] iOS 15
* [ ] iOS 16
* [ ] macOS 10.15
* [ ] macOS 11
* [ ] macOS 12

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants