Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NTP Search Bar feature flag #1023

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Add NTP Search Bar feature flag #1023

merged 6 commits into from
Oct 24, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Oct 17, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/72649045549333/1208262951113965/f
iOS PR: duckduckgo/iOS#3449
macOS PR: duckduckgo/macos-browser#3409
What kind of version bump will this require?: Minor

Description:
This change adds a feature flag to control availability of New Tab Page search field on macOS.
iOS is not affected.

Steps to test this PR:
Verify that CI is green.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy merged commit a7de5bc into main Oct 24, 2024
7 checks passed
@ayoy ayoy deleted the dominik/ntp-search-bar branch October 24, 2024 08:51
samsymons added a commit that referenced this pull request Oct 28, 2024
* main:
  Use cookie to share subscription access token on DDG domains (#1034)
  update css dependency (#1037)
  Email parsing improved (#1016)
  Add NTP Search Bar feature flag (#1023)
  VPN logs fix (#1030)
  Add AI Chat feature flag (#1031)
  fix breakByRaisingSigInt mistakenly called when run w/o debugger (#1029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants