Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresponsive Duck Player button in custom tabs #5219

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix unresponsive Duck Player button in custom tabs #5219

wants to merge 1 commit into from
+46 −16

Conversation

CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Oct 30, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1207252092703676/1208638046607284/f

Description

Steps to test this PR

Feature 1

  • Set Duck Player to Always and Open Duck Player in New tab to enabled
  • Open a YouTube video on a custom tab
  • Click the button to open in duck player
  • Check Duck Player is opened

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@CrisBarreiro Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CrisBarreiro and the rest of your teammates on Graphite Graphite

@CrisBarreiro CrisBarreiro marked this pull request as ready for review October 30, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshliebe joshliebe Awaiting requested review from joshliebe

At least 1 approving review is required to merge this pull request.

Assignees

@joshliebe joshliebe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrisBarreiro @joshliebe