Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trackers network onboarding dialog as required #5216

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Oct 30, 2024

Task/Issue URL: https://app.asana.com/0/1201807753394693/1208648980707159/f

Description

Remove trackers network from required onboarding dialogs to show

Steps to test this PR

  • Fresh install from branch
  • Finish onboarding (Search suggestions dialog, serp dialog, site suggestions dialog, trackers dialog, end dialog)
  • Check "Completing DAX ONBOARDING" appears when you dismiss the last dialog

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nalcalag and the rest of your teammates on Graphite Graphite

@nalcalag nalcalag marked this pull request as ready for review October 30, 2024 15:03
Copy link
Contributor

@CrisBarreiro CrisBarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@nalcalag nalcalag merged commit ec2f1e0 into develop Oct 31, 2024
8 checks passed
@nalcalag nalcalag deleted the feature/noelia/app_stage_established_bug branch October 31, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants