XDR iocs integration- 'XSOAR Comment Field Exporting To XDR' parameter is handled incorrectly #36658
+209
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
|
The fix was checked with @tcarmeli1 and seems to resolve the issue. |
|
I'll fix the UTs according to the fix and wait with merging the PR since there is an issue with mirroring the 'comments' from XDR to XSOAR @dorschw FYI |
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
rshunim
requested review from
samuelFain,
YuvHayun,
altmannyarden,
idovandijk,
michal-dagan and
amshamah419
as code owners
rshunim
removed request for
amshamah419,
thefrieddan1,
sapirshuker,
JudahSchwartz and
shmuel44
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
|
@tcarmeli1 @dorschw please review it both of you |
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-11945
Description
Due to a change in the parameter type (from type 0 - text, to type 16 - list), we encounter an error when updates are sent from XDR to XSOAR.
This error occurs because a list is being used as a key in a dictionary.
Handling it in this fix.
Must have