feat: inherit CommandError (also) from subprocess.CalledProcessError
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the DataLad world `CommandError` was traditionally a `RuntimeError`. Whether or not that makes sense in the general case, one can have different opinions about. The rest of the world is using `subprocess.CalledProcessError`. This exception type is very similar to `CommandError` in the properties that it can capture. It is only missing the CWD info, and the context message that comes with `RuntimeError` (see class docs). This change connects the two worlds, by inheriting from both `RuntimeError` and `CalledProcessError`, and using the properties of both, where possible. The behavior of `CommandError` remains unchanged, but it will now also work with code that expects a `subprocess` exception.
|
Code Climate has analyzed commit f167ef7 and detected 0 issues on this pull request. View more on Code Climate. |
|
I am closing this again, because it cannot be done cleanly. The reason is that We could select a magic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the DataLad world
CommandErrorwas traditionally aRuntimeError. Whether or not that makes sense in the general case, one can have different opinions about.The rest of the world is using
subprocess.CalledProcessError. This exception type is very similar toCommandErrorin the properties that it can capture. It is only missing the CWD info, and the context message that comes withRuntimeError(see class docs).This change connects the two worlds, by inheriting from both
RuntimeErrorandCalledProcessError, and using the properties of both, where possible.The behavior of
CommandErrorremains unchanged, but it will now also work with code that expects asubprocessexception.