Fix handling of multiple encoding errors in decode_bytes input chunks.
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that was detected by @mih. Due to this bug, multiple encoding errors in a single input chunk of `decode_bytes` lead to unexpected decoding-exceptions. The commit also adds a regression test to enure that multiple encoding errors in a single input chunk are handled properly.
|
Code Climate has analyzed commit 31876e7 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
=======================================
Coverage 98.00% 98.01%
=======================================
Files 19 19
Lines 652 655 +3
Branches 118 118
=======================================
+ Hits 639 642 +3
Misses 7 7
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was detected by @mih and addressed here. Due to this bug, multiple encoding errors in a single input chunk of
decode_byteslead to unexpected decoding exceptions.The PR adds a regression test to ensure that multiple encoding errors in a single input chunk are handled properly.