ci(typeannotation): GitHub action to check files changed in a PR #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is that `pyproject.toml` is read in many contexts. These symbols are niceties that nevertheless impact platform compatibility. Reading the file with the default platform encoding on windows (`cp1252`) fails, because these symbols cannot be mapped. Software should be able to handle UTF, but we cannot afford to make a point in this crucial file.
This amends the `mypy-pr` workflow and runs a full check on the entire project on `push`. We may want to have the PR-variant be a critical check to pass, and this additional one be an information items of an (unrelated) problem that needs fixing. Rationale is that Python version upgrades, and mypy improvements may introduce test failures at any time, and we cannot ask individual PR authors to deal with them immediately for code that is unrelated to a PR. Closes: #12
|
Code Climate has analyzed commit 1b646db and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 2 2
Lines 4 4
=======================================
Hits 2 2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.