fix(gitworktree): decode bytes before itemization
#741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`decode_bytes()` can yield multiple output chunks for one input chunk (in the case of decoding errors). This implies that it cannot be meaningfully used after `itemize()` without threatening the semantics of the items (i.e., with split-by-line items are no longer unique lines). For this reason, this commit changes the order of these helpers in the `gitworktree()` implementation. Refs: https://github.com/datalad/datalad-next/issues/740
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
+ Coverage 92.47% 92.51% +0.04%
==========================================
Files 195 195
Lines 14301 14301
Branches 2162 2162
==========================================
+ Hits 13225 13231 +6
+ Misses 812 804 -8
- Partials 264 266 +2 ☔ View full report in Codecov by Sentry. |
mih
added a commit
that referenced
this pull request
Jul 13, 2024
Follow-up to #741, fixing the rest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decode_bytes()can yield multiple output chunks for one input chunk (in the case of decoding errors). This implies that it cannot be meaningfully used afteritemize()without threatening the semantics of the items (i.e., with split-by-line items are no longer unique lines).For this reason, this commit changes the order of these helpers in the
gitworktree()implementation.Refs: datalad/datasalad#35