Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test aspects requiring published datasets #217

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

mih
Copy link
Member

@mih mih commented Mar 13, 2023

ATM we are no capable of cleaning up such datasets after a testrun, because we do not have superuser permissions on demo.dataverse.org

This also removed the now obsolete test fixtures.

Issue #216 tracks a suitable fix.

Closes #215

ATM we are no capable of cleaning up such datasets after a testrun,
because we do not have superuser permissions on demo.dataverse.org

This also removed the now obsolete test fixtures.

Issue datalad#216 tracks a suitable fix.

Closes datalad#215
Previously, not being able to remove a dataset/collection would be
silently ignored and lead to pilling up of cruft on the test instance.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.05 🎉

Comparison is base (a61ba00) 90.18% compared to head (bdbfe57) 91.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   90.18%   91.24%   +1.05%     
==========================================
  Files          15       15              
  Lines         815      788      -27     
==========================================
- Hits          735      719      -16     
+ Misses         80       69      -11     
Impacted Files Coverage Δ
datalad_dataverse/conftest.py 100.00% <ø> (ø)
...d_dataverse/tests/test_create_sibling_dataverse.py 100.00% <ø> (+10.93%) ⬆️
datalad_dataverse/tests/test_pydataverse.py 100.00% <ø> (ø)
datalad_dataverse/tests/fixtures.py 93.18% <100.00%> (+5.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mih mih merged commit e74a50f into datalad:main Mar 13, 2023
@mih mih deleted the bf-215 branch March 13, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot clean up published datasets
2 participants