[Fix] Minor fix in error message for generic error #799
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsculptor
changed the title
dsculptor
force-pushed
the
raj/minor-fix
branch
3 times, most recently
from
e4098e1
to
bfe9b0b
Compare
dsculptor
changed the title
dsculptor
force-pushed
the
raj/minor-fix
branch
from
bfe9b0b
to
15940f2
Compare
3 tasks
mgyucht
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Thanks @dsculptor.
Let's extend this with one more change. In particular, I want to ensure that any error that is not parsed by any of the current error parsers is still handled in a graceful manner. To do this, let's implement a new error parser that is a catch-all error parser that just sets the entire response body as the message. That way, we never need to use this message in the error directly, as this error parser will always succeed. However, we can still log a message saying that we were unable to parse the error and fell back to this catch-all case.
| @@ -38,7 +38,7 @@ def _unknown_error(response: requests.Response) -> str: | |||
| return ( | |||
| 'This is likely a bug in the Databricks SDK for Python or the underlying ' | |||
| 'API. Please report this issue with the following debugging information to the SDK issue tracker at ' | |||
| f'https://github.com/databricks/databricks-sdk-go/issues. Request log:```{request_log}```') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Minor fix in error message for generic error
Tests
make testrun locallymake fmtappliedSame as: #767