Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added retry logic to token refresh to deal with #672

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thijs-nijhuis
Copy link

Changes

The logic that fetches an initial access_token has a fall back/retry path for SPA applications which need an 'origin' header. For the part that fetches a refresh token, this fall back was not there. Instead, an 'origin' would always be set for Azure endpoints but this causes issues with application that use the 'Mobile and desktop applications' platform authentication which will throw an error if an 'origin' header is set. This change should fix this issue by tackling both paths in the same way.

Tests

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@sertacosh
Copy link

We need this change implemented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Azure App Registration with 'Mobile and desktop applications' fails refresh because of Origin header
2 participants