Crude skeleton for spikeextractors producer generators #15
Conversation
jwodder
force-pushed
the
enh-spikeextractors
branch
from
bb780b6
to
c9ced18
Compare
|
@yarikoptic I've changed the PR to check out the ephy_testing_data in a cached directory and also updated the rest of the code so that |
|
Thank you @jwodder -- please finish it up to your liking (see the comment pointing to code to be finished) to get it all working and merge it whenever you are satisfied. |
| nwbfile = NWBFile() | ||
| se.NwbRecordingExtractor.write_recording(recording, nwbfile=nwbfile, write_scaled=True) |
There was a problem hiding this comment.
@yarikoptic This bit doesn't seem to work; nwbfile = NWBFile() seems to be erroring out with TypeError: NWBFile.__init__: missing argument 'session_description', missing argument 'identifier', missing argument 'session_start_time'.
There was a problem hiding this comment.
just add some dummy ones. This is just for a test after all
| with tempfile.NamedTemporaryFile() as tf: | ||
| se.NwbSortingExtractor.write_sorting(sorting, tf.name) | ||
| with pynwb.NWBHDF5IO(tf.name, mode="r") as io: | ||
| nwbfile = io.read() |
There was a problem hiding this comment.
@yarikoptic I got the Extractors to run, but the Sorters are failing here with hdmf.backends.io.UnsupportedOperation: Cannot read data from file /var/folders/l7/wrkq93d133d8zpn36fmqrq0r0000gn/T/tmpz8otn54x in mode 'r+'. There are no values..
There was a problem hiding this comment.
is it only for a single extractor or for all of them?
There was a problem hiding this comment.
if single -- just comment it out for now and produce for those for which it produces, and report for those which do not.
If for all -- I guess it is something more fundamental - just add a comment and do not enable the sorters tests
There was a problem hiding this comment.
@yarikoptic It's for all of them.
@jwodder here is a crude idea for what I had in mind in #13 (drafting a PR as dirty as it was before I had to switch to another call/activity...) . WDYT - could we implement it in some way like this?