-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spikeextractors: "data generators"? #13
Comments
@yarikoptic I'm not clear on how to adapt the spikeextractor code to produce NWBFile instances instead of writing the data directly to files. There's also the issue of how to pass the ephy_testing_data to the |
hm... looking at the code I think you can create an instance of NWBFile and pass it as |
test class itself should have those copy pasted for now etc... I will submit a quick PR which would mimic what I had in mind in original description |
argh -- |
an immediate use case is to support tests from spikeextractors: https://github.com/SpikeInterface/spikeextractors/blob/master/tests/test_gin_repo.py
In the original (before #11) state of things I was thinking that
create
could be converted to a generator which would yield(testsuite: str, test_case: str, nwbfile: NWBFile)
tuples. So thesimple1.py:create
could have yielded a singular("core", "simple1", nwbfile)
. Then in case of spikeextractors it could have yielded records like("spikeextractors", "recording/BlackrockRecordingExtractor/blackrock/blackrock_2_1", nwbfile), ... ("spikeextractors", "sorting/BlackrockSortingExtractor/blackrock/blackrock_2_1", nwbfile), ...
. Do you see a nice way to have it implemented?The idea of duplicating the leading
testsuite
record to be able in the future to extend to having a singular generator for extensions, where then leading record would include extension name then.The text was updated successfully, but these errors were encountered: