-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve all asset types being evaluated during upload validation #1818
Conversation
@yarikoptic Moved to draft -- going to blame lack of coffee on my side for not making this initially a draft 😄 |
Cc @jwodder @yarikoptic @waxlamp -- since I'm submitting via a fork, I don't think that the GitHub Actions pipeline for |
@aaronkanzer I have added you to the @dandi/dandiarchive team, so you should be able to push a branch to this fork for a PR to gain access to all the secrets. Please resubmit this PR |
Closing to move code to: #2062 |
Relates to /linc-archive/pull/34 and #1814
During validation of
zarr
based datasets, a validation check occurs on theassetSummary
field in thedandiset.yaml
Prior to this PR, the only "assets" evaluated were "blob". In the query that is updated in this PR, the checks for
size
are expanded to not justblob
but other "asset" types within the Asset model -- see link below:dandi-archive/dandiapi/api/models/asset.py
Lines 137 to 145 in 1be249a
Prior to the fix in this PR, the following validation would fail on assets in
dandischema
such aszarr
: https://github.com/dandi/dandi-schema/blob/bdb7dd681435f1092814041eb01eb4fabe87bf57/dandischema/models.py#L1497