Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style issues found by Ruff #1741

Merged
merged 20 commits into from
Nov 9, 2023
Merged

Fix style issues found by Ruff #1741

merged 20 commits into from
Nov 9, 2023

Conversation

brianhelba
Copy link
Collaborator

None of these changes should affect logical behavior.

Arbitrary style decisions (like using parentheses in Pytest decorators, but not in raised exceptions) are determined by accepting Ruff's default settings. These are generally auto-fixable by (future usage of) Ruff, so it shouldn't impose any burden for developers to change their habits.

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianhelba brianhelba merged commit 5beddfa into master Nov 9, 2023
10 checks passed
@brianhelba brianhelba deleted the ruff-fixes branch November 9, 2023 18:50
@dandibot
Copy link
Member

🚀 PR was released in v0.3.62 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants