-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize dandiset owner PUT endpoint #1737
Conversation
d2d220a
to
df5e356
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looking at this again, the original ORM expression I wrote can be simplified - see 5cb05e6. I tested it and it works just as well as the previous query. |
@mvandenburgh I noticed that we're still calling the Let me know what you think. Sorry for the trampling, it wasn't possible to achieve the whole diff with github suggestions. Update I've fixed the tests and linting, sorry about that. All should be good now. |
f3b362c
to
28f0dca
Compare
Now that django-allauth uses a regular JSONField for `SocialAccount.extra_data`, we can optimize the dandisets owner query.
28f0dca
to
8b48229
Compare
8b48229
to
b0283e2
Compare
b0283e2
to
7eff07b
Compare
🚀 PR was released in |
Now that django-allauth uses a regular JSONField for
SocialAccount.extra_data
, we can optimize the dandisets owner PUT endpoint to be more efficient and do less SQL queries. See release notes for allauth here https://github.com/pennersr/django-allauth/blob/main/ChangeLog.rst#0580-2023-10-26