Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ING-827: Added support for pinning queries to an endpoint. #283

Merged
merged 1 commit into from
Jul 9, 2024
Merged

ING-827: Added support for pinning queries to an endpoint. #283

merged 1 commit into from
Jul 9, 2024

Conversation

brett19
Copy link
Member

@brett19 brett19 commented Jul 5, 2024

No description provided.

@brett19 brett19 requested review from chvck and Westwooo July 5, 2024 20:00
@brett19 brett19 changed the base branch from master to ING-828_endpoint-identifiers July 6, 2024 00:03
@brett19 brett19 force-pushed the ING-828_endpoint-identifiers branch from 9ed6df8 to 3bc3a00 Compare July 6, 2024 00:11
@brett19 brett19 force-pushed the ING-827_query-pinning branch 2 times, most recently from ccc829e to 8b5b3f2 Compare July 6, 2024 00:17
chvck
chvck reviewed Jul 8, 2024
View reviewed changes
agentmanager_int_test.go Outdated Show resolved Hide resolved
@brett19 brett19 force-pushed the ING-828_endpoint-identifiers branch from 3bc3a00 to a5788a8 Compare July 8, 2024 19:38
Westwooo
Westwooo previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@Westwooo Westwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brett19 brett19 force-pushed the ING-828_endpoint-identifiers branch from a5788a8 to 653f683 Compare July 9, 2024 16:29
Base automatically changed from ING-828_endpoint-identifiers to master July 9, 2024 16:42
@brett19 brett19 dismissed Westwooo’s stale review July 9, 2024 16:42

The base branch was changed.

@brett19 brett19 merged commit f8affca into master Jul 9, 2024
4 checks passed
@brett19 brett19 deleted the ING-827_query-pinning branch July 9, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvck chvck chvck approved these changes

@Westwooo Westwooo Westwooo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brett19 @chvck @Westwooo