Adapt to Coq PR #19301: unify the syntax of definition and theorem #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Could you please add directives for ppx_optcomp? |
herbelin
force-pushed
the
main+adapt-coq-pr19301-ceps42-unify-definition-theorem
branch
from
f5c98e4
to
3298bda
Compare
In particular, VernacStartTheoremProof and VernacDefinition are merged.
herbelin
force-pushed
the
main+adapt-coq-pr19301-ceps42-unify-definition-theorem
branch
from
3298bda
to
4793087
Compare
Looks ok now. Thanks for telling. |
gares
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular,
VernacStartTheoremProofandVernacDefinitionare now only one common entry and we adaptdocument.mlto it (hoping I'm not doing something wrong).To be merged synchronously with coq/coq#19301 when the latter is ready.