Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManifestSummary popover heigh max to 100vh in small viewport #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryprice
Copy link

@ryprice ryprice commented Jan 17, 2024

Changes in this pull request

The root popover, ManifestSummary, expands beyond the bounds of the page in small viewports. See #93. This change makes #container flex flow column layout so in cases where #content-container is larger than #container, the 'view more' button stays on screen.

Screen.Recording.2024-01-16.at.7.12.46.PM.mp4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • All applicable changes have been documented
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment

@ryprice
Copy link
Author

ryprice commented Jan 17, 2024

This approach only works assuming the popover is always positioned to the left/right or over the cai-indicator, not below or above where it might not have 100vh. I'm realizing there may be a way to do this more sustainably by using floating-ui size.

@dkozma dkozma requested a review from emensch January 18, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant