ManifestSummary popover heigh max to 100vh in small viewport #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryprice
force-pushed
the
manifest-summary-100vh
branch
from
501c88d
to
1e89ed1
Compare
|
This approach only works assuming the popover is always positioned to the left/right or over the cai-indicator, not below or above where it might not have 100vh. I'm realizing there may be a way to do this more sustainably by using floating-ui size. |
ryprice
force-pushed
the
manifest-summary-100vh
branch
from
1e89ed1
to
23900ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
The root popover, ManifestSummary, expands beyond the bounds of the page in small viewports. See #93. This change makes
#containerflex flow column layout so in cases where#content-containeris larger than#container, the 'view more' button stays on screen.Screen.Recording.2024-01-16.at.7.12.46.PM.mp4
Types of changes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment