-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JGO_CACHE_DIR to specify cache dir within conda env #4
Use JGO_CACHE_DIR to specify cache dir within conda env #4
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Should we create the |
I don't think there is any need to create it as part of the build. |
Might need to forgo any testing with calls to
|
Will remove the tests from this PR, testing will need to wait until scijava/jgo#22, scijava/jgo#24, and scijava/jgo#25 are resolved. After that, we can run tests like this: test:
requires:
- openjdk
- maven
commands:
- test "$(jgo -r ij=https://maven.imagej.net/content/groups/public org.scijava:jgo-test:0.1.0 yay jgo!)" = "yay jgo!" # [unix]
- for /f %%i in ('jgo -r ij=https://maven.imagej.net/content/groups/public org.scijava:jgo-test:0.1.0 yay jgo!') do set JGO_OUTPUT="%%i"; if not "%JGO_OUTPUT%" == "yay jgo!" exit 1 # [win] |
LGTM after everything is green. It's good to have sanity tests in the recipe. |
Ah ha, I warned you, didn't I? 😜 Thanks so much for working on this, guys. |
Checklist
Bumped the build number because we do not have a new release of
jgo
yet. We should wait with this PR until we have that release, otherwise the environment variables will not have any effect. Check list before merge:jgo-0.2.0
0.2.0
1000
run test with simple jarIs this PR a fix for #1? Or are there other issues in there that would need to be adressed separately?