Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JGO_CACHE_DIR to specify cache dir within conda env #4

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Use JGO_CACHE_DIR to specify cache dir within conda env #4

merged 1 commit into from
Nov 28, 2018

Conversation

hanslovsky
Copy link
Contributor

@hanslovsky hanslovsky commented Nov 27, 2018

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)

Bumped the build number because we do not have a new release of jgo yet. We should wait with this PR until we have that release, otherwise the environment variables will not have any effect. Check list before merge:

  • release jgo-0.2.0
  • update recipe version to 0.2.0
  • reset build number to 1000
  • run test with simple jar

Is this PR a fix for #1? Or are there other issues in there that would need to be adressed separately?

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ctrueden
Copy link
Member

ctrueden commented Nov 27, 2018

https://pypi.org/project/jgo/0.2.0/
https://github.com/scijava/jgo/releases/tag/0.2.0

@hanslovsky hanslovsky mentioned this pull request Nov 27, 2018
@jakirkham
Copy link
Member

Should we create the JGO_CACHE_DIR as part of the build? Also if we do that, we may need to leave a dummy file in there to ensure the directory is kept in the package.

@hanslovsky
Copy link
Contributor Author

I don't think there is any need to create it as part of the build. jgo will create it as needed.

@hanslovsky
Copy link
Contributor Author

Might need to forgo any testing with calls to jgo until we have the auto link-mode: scijava/jgo#22, failure log from linux builds:

ERROR 2018-11-27 19:39:42,594: [Errno 18] Invalid cross-device link: '/home/conda/.m2/repository/org/jetbrains/kotlin/kotlin-stdlib/1.2.50/kotlin-stdlib-1.2.50.jar' -> '/home/conda/feedstock_root/build_artifacts/jgo_1543347517038/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/jgo/org/scijava/jgo-test/0.1.0/kotlin-stdlib-1.2.50.jar'

@hanslovsky
Copy link
Contributor Author

Will remove the tests from this PR, testing will need to wait until scijava/jgo#22, scijava/jgo#24, and scijava/jgo#25 are resolved.

After that, we can run tests like this:

test:
  requires:
    - openjdk
    - maven
  commands:
    - test "$(jgo -r ij=https://maven.imagej.net/content/groups/public org.scijava:jgo-test:0.1.0 yay jgo!)" = "yay jgo!"  # [unix]
    - for /f %%i in ('jgo -r ij=https://maven.imagej.net/content/groups/public org.scijava:jgo-test:0.1.0 yay jgo!') do set JGO_OUTPUT="%%i"; if not "%JGO_OUTPUT%" == "yay jgo!" exit 1  # [win]

@hadim
Copy link
Member

hadim commented Nov 27, 2018

LGTM after everything is green. It's good to have sanity tests in the recipe.

@ctrueden
Copy link
Member

Invalid cross-device link

Ah ha, I warned you, didn't I? 😜

Thanks so much for working on this, guys.

@hanslovsky hanslovsky merged commit 8b5ec0d into conda-forge:master Nov 28, 2018
@hanslovsky hanslovsky deleted the jgo-cache-dir-environment-variable branch November 28, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants