Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- News article will be append instead of replacing the whole html element's content.
- Remove the space between card border and card image.
- So they don't make a mess in the DevTools' Elements panel. - Is it OK? https://stackoverflow.com/questions/13075502/is-it-bad-to-have-script-tag-inside-div
In both fetch() and result.json()
- Use article tag. - Prevent reference to null (article without an image), otherwise the browser will try to look for the image at localhost/null and the console will show an error GET http://localhost:5500/null 404 (Not Found)
- Only increase page variable after a success response.
Add articles info and error banner
- Remove the form. - Use bootstrap style. - Uncenter the page name.
- User can press Enter to search. - The search button only clickable when there is a search term. - Focus to the text input so user can type immediately after visit the page.
Reformat header and improve the search bar
On mobile device: - The search bar won't be too small. - The articles info won't overlay the load more button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @nngocjade @lethang7794 @everythinginmoderation2