Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radix-vue Migration from v1.9.3** → **v1.9.4 and v2(RekaUI) codemods #1294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dfordp
Copy link

@dfordp dfordp commented Aug 29, 2024

Radix Vue (Reka UI)

radix-vue → reka-ui (radix-vue v2)

Remove filter-function props

  • Combobox has been refactored and improve to support better custom filtering.

Additional Details

Rename controlled state to v-model

[Remove deprecated step prop](radix-vue/radix-vue@ec146dd)


v1.9.3v1.9.4

  • Link to Official Upgrade Guide: [[Migration Link](https://github.com/radix-vue/radix-vue/releases)]

Recalculate tabs indicator position on direction change

  • When the dir attribute of the page was changed dynamically, the indicator position in the Tabs component did not adjust to reflect the new text direction. This caused the indicator to remain in the incorrect position, resulting in a poor user experience.
  • Updated the Tabs component to correctly update the indicator position when the dir attribute of the page changes. This ensures that the indicator is always positioned correctly according to the current text direction.
  • Added a watcher for the dir attribute to dynamically update the indicator position in the Tabs component when the text direction changes.
  • https://codemod.com/registry/vue-v1-9-4-tab-tabs-indicator-position-bug-fix

Use watchPostEffect for placed update

  • When floating-ui returned isPositioned=true, radix-vue immediately emitted an event to focus on the selected item in the Select component. However, at this point, the PopperContent element did not yet have the correct transform CSS property set, resulting in the Popper being positioned at coordinates (0, -200%).
  • Changed the watchEffect to watchPostEffect to ensure that the event is emitted only after the DOM has been updated and the Popper is correctly positioned on the page (e.g., at coordinates 84px, 231px). This ensures that focusSelectedItem is called only after the Popper has been properly positioned.
  • Replaced watchEffect with watchPostEffect to emit the positioning event after DOM updates.
  • https://go.codemod.com/UYq6hN

Missing data-disabled in NumberField

Fix(NavigationMenu): client-side nav was prevented by RouterLink

  • When using NavigationMenuLink together with NuxtLink according to the documentation the menu does not dismiss when clicking on a link.
  • I would expect the menu to dismiss, or at least have an option to do so.
  • https://go.codemod.com/DERwRX3

Copy link

vercel bot commented Aug 29, 2024

@dfordp is attempting to deploy a commit to the Codemod Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants