refactor(notification): dismissDirection prop name has changed to sli… (

#320)

* refactor(notification): dismissDirection prop name has changed to slideDirection to remove confusion

BREAKING CHANGE: Prop name change

fix #138

* fix(notification): fix namespace check

* fix(notification): namespace fix

package.json

@@ -1,6 +1,6 @@
 {
   "name": "czifui",
-  "version": "0.0.43",
+  "version": "0.0.44",
   "main": "dist/index.cjs.js",
   "module": "dist/index.esm.js",
   "repository": {
@@ -52,7 +52,7 @@
     "concurrently": "^6.0.0",
     "css-font": "^1.2.0",
     "cz-conventional-changelog": "^3.3.0",
-    "czifui": "file:czifui-v0.0.43.tgz",
+    "czifui": "file:czifui-v0.0.44.tgz",
     "eslint": "^7.32.0",
     "eslint-config-airbnb-typescript": "^12.3.1",
     "eslint-config-prettier": "^8.1.0",

src/common/styles-dictionary/css/variables.css

@@ -1,6 +1,6 @@
 /**
  * Do not edit directly
- * Generated on Sat, 18 Feb 2023 23:22:38 GMT
+ * Generated on Tue, 21 Feb 2023 22:20:04 GMT
  */
 
 :root {

src/common/styles-dictionary/scss/_variables.scss

@@ -1,6 +1,6 @@
 
 // Do not edit directly
-// Generated on Sat, 18 Feb 2023 23:22:38 GMT
+// Generated on Tue, 21 Feb 2023 22:20:04 GMT
 
 $sds-font-letter-spacing-default: 0.3px;
 $sds-font-letter-spacing-caps: 1px;

src/core/Notification/Notification.namespace-test.tsx

@@ -7,7 +7,7 @@ const NotificationNameSpaceTest = (props: NotificationProps) => {
     <Notification
       autoDismiss
       dismissed={false}
-      dismissDirection="left"
+      slideDirection="left"
       intent="info"
       onClose={noop}
       buttonOnClick={noop}

src/core/Notification/index.stories.tsx

@@ -11,7 +11,7 @@ const Demo = (props: Args): JSX.Element => {
     onClose,
     buttonOnClick,
     buttonText,
-    dismissDirection,
+    slideDirection,
     extraContent,
     autoDismiss,
   } = props;
@@ -34,7 +34,7 @@ const Demo = (props: Args): JSX.Element => {
         <Notification
           autoDismiss={autoDismiss}
           dismissed={dismissed}
-          dismissDirection={dismissDirection}
+          slideDirection={slideDirection}
           intent={intent}
           onClose={onClose}
           buttonOnClick={action("onClick")}
@@ -66,7 +66,7 @@ const Demo = (props: Args): JSX.Element => {
       <Notification
         autoDismiss={autoDismiss}
         dismissed={dismissed}
-        dismissDirection={dismissDirection}
+        slideDirection={slideDirection}
         intent={intent}
         onClose={onClose}
         {...props}
@@ -95,10 +95,6 @@ export default {
     buttonOnClick: {
       control: { type: "boolean" },
     },
-    dismissDirection: {
-      control: { type: "radio" },
-      options: ["left", "right"],
-    },
     extraContent: {
       control: { type: "boolean" },
     },
@@ -116,6 +112,10 @@ export default {
       },
       options: [action("onClick"), undefined],
     },
+    slideDirection: {
+      control: { type: "radio" },
+      options: ["left", "right"],
+    },
   },
   component: Demo,
   title: "Notification",
@@ -129,9 +129,9 @@ Default.args = {
   autoDismiss: false,
   buttonOnClick: false,
   buttonText: "click me",
-  dismissDirection: "left",
   extraContent: false,
   intent: "success",
+  slideDirection: "left",
 };
 
 Default.parameters = {
@@ -150,11 +150,11 @@ const storyRow = {
 const LivePreviewDemo = (props: Args): JSX.Element => {
   return (
     <div style={storyRow as React.CSSProperties}>
-      <Notification dismissDirection="left" intent="info" {...props}>
+      <Notification slideDirection="left" intent="info" {...props}>
         this is a notification
       </Notification>
       <Notification
-        dismissDirection="left"
+        slideDirection="left"
         intent="info"
         buttonOnClick={action("onClick")}
         buttonText="click me"
@@ -163,7 +163,7 @@ const LivePreviewDemo = (props: Args): JSX.Element => {
         this is a notification
       </Notification>
       <Notification
-        dismissDirection="left"
+        slideDirection="left"
         intent="info"
         buttonOnClick={action("onClick")}
         buttonText="click me"
@@ -192,7 +192,7 @@ LivePreview.parameters = {
 const TestDemo = (props: Args): JSX.Element => {
   return (
     <Notification
-      dismissDirection="left"
+      slideDirection="left"
       intent="info"
       {...props}
       data-testid="notification"

src/core/Notification/index.tsx

@@ -11,7 +11,7 @@ export interface NotificationProps {
   buttonOnClick?: (event: React.SyntheticEvent) => void;
   buttonText?: string;
   dismissed?: boolean;
-  dismissDirection: "left" | "right";
+  slideDirection: "left" | "right";
   extraContent?: boolean;
   intent: "info" | "error" | "success" | "warning";
 }
@@ -25,7 +25,7 @@ const Notification = ({
   autoDismiss,
   children,
   dismissed,
-  dismissDirection = "left",
+  slideDirection = "left",
   intent,
   onClose,
   buttonOnClick,
@@ -71,7 +71,7 @@ const Notification = ({
     <>
       <Slide
         in={!hide}
-        direction={dismissDirection}
+        direction={slideDirection}
         mountOnEnter
         unmountOnExit
         timeout={250}

yarn.lock

@@ -7754,9 +7754,9 @@ cz-conventional-changelog@^3.3.0:
   optionalDependencies:
     "@commitlint/load" ">6.1.1"
 
-"czifui@file:czifui-v0.0.43.tgz":
-  version "0.0.43"
-  resolved "file:czifui-v0.0.43.tgz#a52f1c598aabdd7cb9671de05fc438f9f9153329"
+"czifui@file:czifui-v0.0.44.tgz":
+  version "0.0.44"
+  resolved "file:czifui-v0.0.44.tgz#16459b590b623dd9b6711f247dca597fb9422d72"
 
 damerau-levenshtein@^1.0.8:
   version "1.0.8"