fix: Do not set S3 kms encryption by default #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayengee are you sure you want to do this? Encryption is generally encouraged |
|
@kuannie1 - yes. This is specifically KMS encryption (which I introduced in July as an option), rather the Server Side Encryption (SSE). KMS encryption is great in that it allows cross-account bucket access, but also creates overhead as anyone accessing that bucket would also require access to the KMS key This PR doesn't remove encryption but rather just switches the default protocol back to SSE |
jakeyheath
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previous change set s3 KMS encryption by default
Test Plan
Say unittests, or list out steps to verify changes.
References
(Optional) Additional links to provide more context.