Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

StackDriver Propagator: Make the google header configurable #818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nhumrich
Copy link

@nhumrich nhumrich commented Jul 2, 2020

Other google (stackdriver) propagator libraries in open census (for example, python) allow for the header to be configurable. I already have a bunch of projects using a different header. This change allows the header with the trace-context info to be configurable if needed.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nhumrich
Copy link
Author

nhumrich commented Jul 2, 2020

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@nhumrich
Copy link
Author

nhumrich commented Jul 2, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 2, 2020
@nhumrich nhumrich force-pushed the master branch 2 times, most recently from 3d197d3 to 7a9bc44 Compare July 2, 2020 16:51
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #818 into master will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
- Coverage   97.02%   96.52%   -0.51%     
==========================================
  Files          13        9       -4     
  Lines         841      661     -180     
  Branches       51       69      +18     
==========================================
- Hits          816      638     -178     
+ Misses         25       23       -2     
Impacted Files Coverage Δ
src/index.ts 100.00% <0.00%> (ø)
src/binary-format.ts
src/resource-labels.ts
src/grpc.ts
test/test-detect-resource.ts
src/grpc-stats/client-stats.ts
src/detect-resource.ts
src/grpc-stats/stats-common.ts
src/grpc-stats/common-distributions.ts
src/grpc-stats/server-stats.ts
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1edb7e...25ffeb7. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants