-
Notifications
You must be signed in to change notification settings - Fork 96
StackDriver Propagator: Make the google header configurable #818
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
3d197d3
to
7a9bc44
Compare
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
==========================================
- Coverage 97.02% 96.52% -0.51%
==========================================
Files 13 9 -4
Lines 841 661 -180
Branches 51 69 +18
==========================================
- Hits 816 638 -178
+ Misses 25 23 -2 Continue to review full report at Codecov.
|
Other google (stackdriver) propagator libraries in open census (for example, python) allow for the header to be configurable. I already have a bunch of projects using a different header. This change allows the header with the trace-context info to be configurable if needed.